On 22. aug. 2013 16:52, Morten Brekkevold wrote:
Hi Ole Martin, good to hear from you again, it's been a while!
Likewise!
We would have to do a proper code review before accepting this into NAV, though.
Indeed. There are a lot of things I'd like to clean up even before the code review, but I think what I've got is a good start.
NAV 3.15 also tosses out Cheetah completely, in favor of Django templates. This means that any Cheetah templates you have that inherit from NAV's base templates will no longer work.
Happily, since writing the toolinst I have converted all our tools to Django. The only one left was netbscan, but now that it has been included in machinetracker there is no need for this anymore. I've tossed it out.
Assuming you ditch the old tech in your own code, the install tool may become a lot simpler. I have some ideas of my own, but I'd rather hear your comments and read your code first.
I look forward to hearing your ideas. The tool is indeed a lot simpler now, but there is stil a lot of room for improvement.
We've grown quite fond of using Bitbucket for code reviews via pull requests. You should probably fork my NAV mirror repository [1] there for any further (public) work you might want to do on NAV.
Will do!