I have tested your update and it seems to work fine with WeatherGoose 2.
_________________ Mvh. Marius Halden IT-Lærling
-----Opprinnelig melding----- Fra: Morten Brekkevold [mailto:morten.brekkevold@uninett.no] Sendt: 24. mai 2011 14:49 Til: Halden Marius Kopi: nav-dev@uninett.no Emne: Re: SV: Weathergoose 2 support (Bug #737446)
On Wed, 18 May 2011 14:40:32 +0200 "Halden Marius" Marius.Halden@hin.no wrote:
Hi again.
I have rewritten the patch to have one handler which support both the old weathergoose and weathergoose 2. Unfortunately I have only had the opportunity to test it with a weathergoose 2, but it should work with the old version as well. The handler now also re-uses the old alert types for both versions of the weathergoose. In other words, the duplicates in alertmsg.conf and alert filters are removed.
Thanks! Not sure that the code itself was an improvement (but then, the old code needed some cleanup as well).
Anyway, your patches prompted me to do some tinkering of my own. Based on your original patch, I wrote these changes:
https://bitbucket.org/mbrekkevold/nav-wxgoose2/changesets
I've added some unit tests for this code as well (run them using `make check` in the python dir), but I'm unable to do a live test, as it seems our own WeatherGoose 1 is not functioning at the moment.
Could you test this code on your WeatherGoose 2?
(There also seems to be lots of other tiny issues with the original plugin code that I haven't addressed).
-- Morten Brekkevold UNINETT